Fix#1: Don't sleep after the final exhausted retry attempt in
_graph_request(). The sleep on the last iteration was pure overhead —
the loop exits immediately after, so the caller just waited an extra
backoff period for no reason. Guard with attempt < _MAX_RETRIES - 1.
Task 10: Add threading.Lock (_edits_lock) for all compound operations
on active_edits, which is accessed from both the UI thread and
background edit threads:
- __init__: declare self._edits_lock = threading.Lock()
- open_file: snapshot already_editing and at_limit under the lock,
then release before showing blocking UI dialogs
- process_file: wrap initial dict assignment, waiting=True, the
in-check+waiting=False, and in-check+del under the lock
- on_done_editing_clicked: lock the items() snapshot used to build
waiting_files, preventing iteration over a dict being mutated
Add 8 new unit tests (1 for Fix#1 sleep count, 7 for Task 10 lock).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add module-level _graph_request() that wraps requests.request() with:
- Up to 3 retries on HTTP 429 (rate limited) and 503 (unavailable)
- Exponential backoff capped at 60 s, honouring Retry-After header
- Default timeout=30 s injected via setdefault (caller can override)
Wire all 13 retry-eligible API calls through _graph_request(). The 3
file-upload requests.put(data=f) calls are kept direct since an open
stream cannot be re-read after the first attempt.
Add 9 unit tests covering: success path, 429/503 retry, Retry-After
header, max-retry exhaustion, timeout injection and override.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add timeout= to every requests.get/post/put/patch/delete call so that
background threads cannot hang indefinitely when the network is stalled:
- timeout=30 on all API calls (delete, post, patch, get — 13 locations)
- timeout=120 on file upload calls (requests.put with data= — 3 locations)
to allow sufficient time for large file transfers
Add 1 new unit test that scans the source file and fails if any
requests.* call is missing a timeout= parameter.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace 4 bare `except:` with `except Exception:` (load_settings,
get_txt, get_icon_idx_for_file, process_file cleanup block) so
SystemExit and KeyboardInterrupt are no longer swallowed
- Replace 2 print() calls with logger.error() (__init__ MSAL init,
ensure_valid_token) so errors appear in the configurable log output
- Sanitize item['name'] with os.path.basename() in on_download_clicked
and _download_folder_recursive_sync to prevent path traversal from
server-controlled filenames
- Add 8 new unit tests covering all Task 7 changes
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
19 tests covering:
- I2/I3: STRINGS dict entries (System tab label, status_loading_items)
- I1/C-1/S-2: nav_gen guard logic in _finalize_list_loading
(matching gen applies, stale gen discards, None bypasses guard,
old zero default now correctly treated as stale)
- C1: url=None initialization order in _fetch_tree_children_bg
- S2: dead SITE branch absent from _append_list_items
- S-1: is_breadcrumb parameter removed from _navigate_to_item_data
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
